[padb-devel] [padb commit] r57 - Enable warnings for the Branch and fix anything it throws up.

codesite-noreply at google.com codesite-noreply at google.com
Wed Jun 17 12:01:38 BST 2009


Author: apittman
Date: Wed Jun 17 03:26:07 2009
New Revision: 57

Modified:
    branches/full-duplex/src/padb

Log:
Enable warnings for the Branch and fix anything it throws up.


Modified: branches/full-duplex/src/padb
==============================================================================
--- branches/full-duplex/src/padb	(original)
+++ branches/full-duplex/src/padb	Wed Jun 17 03:26:07 2009
@@ -1,4 +1,4 @@
-#!/usr/bin/perl
+#!/usr/bin/perl -w

  # padb. a simple parallel debugging aid from Quadrics.

@@ -2862,7 +2862,6 @@
      }
      foreach my $hash (@all) {
          my @res;
-        my @res;
          foreach my $key (@proc_format_array) {
              my $value = "??";
              if ( defined $hash->{$key} ) {
@@ -5083,7 +5082,7 @@
          chomp $l;
          my @stats = split( / /, $l );
          for ( my $i = 0 ; $i <= $#stats ; $i++ ) {
-            output( $vp, "$prefix.$stat_names[$i]: @stats[$i]" );
+            output( $vp, "$prefix.$stat_names[$i]: $stats[$i]" );
          }

      }
@@ -6105,7 +6104,7 @@
          $res->{request} = $cmd;
      }

-    if ( $cmd->{quit} == 1 ) {
+    if ( defined( $cmd->{quit} ) and ( $cmd->{quit} == 1 ) ) {
          exit(0);
      }

@@ -6188,8 +6187,7 @@
      $netdata->{server} = $server;
      $netdata->{key}    = $key;

-    my $sel    = $netdata->{sel};
-    my $server = $netdata->{server};
+    my $sel = $netdata->{sel};

      while ( my @data = $sel->can_read() ) {
          foreach my $s (@data) {




More information about the padb-devel mailing list