[padb] Réf. : Re: [padb-devel] Patch for Support of PBS Pro resource manager

[thipadin.seng-long at bull.net]

Hi,
I have merged your patch against r311, and been testing the overall 
version.
I am doing a kind of step by step, then I not am going through all the 
code,
bugs met are:

1-Loop in a while instruction:

2620 sub pbs_get_lqsub {
2621     my ( $user, $server ) = @_;
2622     my $job;
2623     my $cmd = "qstat -w -n -u $user \@$server";
2624 
2625     my @output = slurp_cmd($cmd);
2626     while (@output) {
2627         if (/\d+\.$server/i) {
.
.
.
.
it issues some kinds of messages plenty on the screen:

Use of uninitialized value in pattern match (m//) at ./padb line 2627.
 at ./padb line 2627
        main::pbs_get_lqsub('thipa', 'xn0') called at ./padb line 2680
        main::pbs_get_data('thipa') called at ./padb line 2688
        main::pbs_get_jobs('thipa') called at ./padb line 3109
        main::job_is_running('27611.xn0', 'thipa') called at ./padb line 
5183
        main::outer_main() called at ./padb line 9048
Use of uninitialized value in pattern match (m//) at ./padb line 2627.
 at ./padb line 2627
        main::pbs_get_lqsub('thipa', 'xn0') called at ./padb line 2680
        main::pbs_get_data('thipa') called at ./padb line 2688
        main::pbs_get_jobs('thipa') called at ./padb line 3109
        main::job_is_running('27611.xn0', 'thipa') called at ./padb line 
5183
        main::outer_main() called at ./padb line 9048
Use of uninitialized value in pattern match (m//) at ./padb line 2627.
 at ./padb line 2627
        main::pbs_get_lqsub('thipa', 'xn0') called at ./padb line 2680
        main::pbs_get_data('thipa') called at ./padb line 2688
        main::pbs_get_jobs('thipa') called at ./padb line 3109
        main::job_is_running('27611.xn0', 'thipa') called at ./padb line 
5183
        main::outer_main() called at ./padb line 9048
:pbs_get_data('thipa') called at ./padb line 2688
        main::pbs_get_jobs('thipa') called at ./padb line 3109
        main::job_is_running('27611.xn0', 'thipa') called at ./padb line 
5183
        main::outer_main() called at ./padb line 9048

 I have to break on the screen to get prompt:
So I guess it is a infinite loop.
I have changed  'while(@output)'  for 'foreach(@output)', to correct this probleme.

2- Job is not found:

So when the loop is disappeared  i can go further:

./padb -O rmgr=pbs -tx 27611.xn0
Job 27611.xn0 is not active
[thipa at xn5]$ qstat
Job id            Name             User              Time Use S Queue
----------------  ---------------- ----------------  -------- - -----
27611.xn0         STDIN            thipa             00:00:06 R workq  
[thipa at xn5]$

The jobs that are display by qstat have the suffice with .xn0 (which is 
the server), 
so we used to pick up the whole job id as input jobid.
So something have to be changed (code or synopsis).

I am waiting for your patch (or reply) to continue.
Thipadin.
More later.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://pittman.org.uk/pipermail/padb-devel_pittman.org.uk/attachments/20091117/38acc8ae/attachment.html>