[padb-devel] [padb] r181 committed - Remove braces from calls to shift.

codesite-noreply at google.com codesite-noreply at google.com
Fri Sep 4 23:03:50 BST 2009


Revision: 181
Author: apittman
Date: Fri Sep  4 15:03:20 2009
Log: Remove braces from calls to shift.

http://code.google.com/p/padb/source/detail?r=181

Modified:
  /branches/cleanup/src/padb

=======================================
--- /branches/cleanup/src/padb	Fri Sep  4 14:52:16 2009
+++ /branches/cleanup/src/padb	Fri Sep  4 15:03:20 2009
@@ -701,7 +701,7 @@
      }

      if (@ranks) {
-        $rank_rng = rng_convert_from_user( shift(@ranks) );
+        $rank_rng = rng_convert_from_user( shift @ranks );

          foreach my $rank (@ranks) {
              rng_merge( $rank_rng, rng_convert_from_user($rank) );
@@ -3005,7 +3005,7 @@
      my @all = array_from_target_namespace( $lines->{target_data}{state} );

      my $o = "";
-    while ( defined( my $v = shift(@all) ) ) {
+    while ( defined( my $v = shift @all ) ) {
          $o .= $v;
      }
      print("$o\n");
@@ -3392,7 +3392,7 @@

      my @leaves;

-    my $root = shift( @{$a} );
+    my $root = shift @{$a};

      my @joints;
      push @joints, $root;
@@ -3515,7 +3515,7 @@
      if ($watch) {
          $cmd = $commands[0];
      } else {
-        $cmd = shift(@commands);
+        $cmd = shift @commands;
      }

      my $req;
@@ -3922,7 +3922,7 @@

      my $value = $rg->[0]->{l};
      if ( $rg->[0]->{l} == $rg->[0]->{u} ) {
-        shift( @{$rg} );
+        shift @{$rg};
      } else {
          $rg->[0]->{l}++;
      }
@@ -3997,8 +3997,8 @@
  sub rng_create_from_array {
      my (@r) = @_;

-    my $rng = rng_convert_from_user( shift(@r) );
-    while ( defined( my $v = shift(@r) ) ) {
+    my $rng = rng_convert_from_user( shift @r );
+    while ( defined( my $v = shift @r ) ) {
          rng_add_value( $rng, $v );
      }
      return $rng;
@@ -6029,7 +6029,7 @@
      my $jiffies = 0;

      # Remove the "cpu" prefix.
-    shift(@usecc);
+    shift @usecc;
      foreach my $usecv (@usecc) {
          $jiffies += $usecv;
      }




More information about the padb-devel mailing list