[padb-devel] [padb] r213 committed - Bug fix: If when re-attaching to a process to get a better stack trace...

[codesite-noreply at google.com]

Revision: 213
Author: apittman
Date: Tue Sep  8 12:39:08 2009
Log: Bug fix: If when re-attaching to a process to get a better stack trace  
the attach fails
check the correct value when reporting an error message.  Furthermore  
checking the
wrong value was causing $gdb to be created which made a further test in the  
code incorrectly
pass and a invalid $gdb handle being passed to gdb_dump_frames_per_thread()  
which was causing
the code to crash with invalid fd messages.

http://code.google.com/p/padb/source/detail?r=213

Modified:
  /branches/cleanup/src/padb

=======================================
--- /branches/cleanup/src/padb	Tue Sep  8 12:34:43 2009
+++ /branches/cleanup/src/padb	Tue Sep  8 12:39:08 2009
@@ -6283,8 +6283,8 @@
                  if ( gdb_attach( $g, $pid ) ) {
                      $gdb = $g;
                  } else {
-                    if ( defined $gdb->{error} ) {
-                        target_error( $vp, $gdb->{error} );
+                    if ( defined $g->{error} ) {
+                        target_error( $vp, $g->{error} );
                      } else {
                          target_error( $vp, 'Failed to attach to process' );
                      }