[padb-devel] [padb] r247 committed - Convert a number of c style for loops into foreach loops.

[codesite-noreply at google.com]

Revision: 247
Author: apittman
Date: Mon Sep 14 05:36:42 2009
Log: Convert a number of c style for loops into foreach loops.

http://code.google.com/p/padb/source/detail?r=247

Modified:
  /branches/cleanup/src/padb

=======================================
--- /branches/cleanup/src/padb	Mon Sep 14 05:06:47 2009
+++ /branches/cleanup/src/padb	Mon Sep 14 05:36:42 2009
@@ -1985,7 +1985,7 @@
          return 0;
      }

-    for ( my $i = 0 ; $i <= $#{$l1} ; $i++ ) {
+    foreach my $i ( 0 .. $#{$l1} ) {
          if ( !defined( ${$l2}[$i] ) || ${$l1}[$i] ne ${$l2}[$i] ) {
              return 0;
          }
@@ -2926,7 +2926,7 @@
          # well.
          my $main_idx;
          my $wait_idx = 0;
-        for ( my $l = 0 ; $l < $#{ $lines->{$tag} } ; $l++ ) {
+        for my $l ( 0 .. $#{ $lines->{$tag} } ) {
              if ( $lines->{$tag}->[$l] =~ /(\w*)\(/ ) {
                  if ( defined $below{$1} ) {
                      $main_idx = $l;
@@ -2977,9 +2977,11 @@
  a: alltoall A: alltoalls w: waiting
  .: consuming CPU cycles ,: using CPU but no queue data -: sleeping *: error
  EOF
-    print $header ;
+
+    print $header;
      my $l = '0';
-    for ( my $i = 1 ; $i < $nprocs ; $i++ ) {
+
+    for my $i ( 1 .. $nprocs - 1 ) {
          if ( $i % 10 == 0 ) {
              $l .= substr $i, 0, 1;
          } elsif ( $i % 5 == 0 ) {
@@ -3642,7 +3644,7 @@
      }
      my $rng = rng_create_empty();

-    for ( my $proc = 0 ; $proc < $comm_data->{nprocesses} ; $proc++ ) {
+    foreach my $proc ( 0 .. $comm_data->{nprocesses} - 1 ) {
          if ( not defined $here{$proc} ) {
              rng_add_value( $rng, $proc );
          }
@@ -6061,8 +6063,8 @@
      foreach my $l ( slurp_file($file) ) {
          chomp $l;
          my @stats = split $SPACE, $l;
-        for ( my $i = 0 ; $i <= $#stats ; $i++ ) {
-            proc_output( $vp, "stat.$stat_names[$i]", $stats[$i] );
+        foreach my $stat ( 0 .. $#stats ) {
+            proc_output( $vp, "stat.$stat_names[$stat]", $stats[$stat] );
          }

      }
@@ -6524,7 +6526,7 @@
                  }
              }

-            for ( my $i = $#frames ; $i >= 0 ; $i-- ) {
+            foreach my $i ( reverse 0 .. $#frames ) {
                  my $frame = $frames[$i];

                  target_error( $vp, "error from gdb: $frame->{error}" )
@@ -6801,7 +6803,7 @@

          foreach my $thread ( sort { $a->{id} <=> $b->{id} } @threads ) {
              my @frames = @{ $thread->{frames} };
-            for ( my $i = $#frames ; $i >= 0 ; $i-- ) {
+            foreach my $i ( reverse 0 .. $#frames ) {
                  my $frame = $frames[$i];
                  if ( defined $fns->{fns}{ $frame->{func} } ) {
                      $fnmode = $fns->{fns}{ $frame->{func} };