[padb] r415 committed - Fix a couple of problem with the new launch_mode code:...
padb at googlecode.com
padb at googlecode.com
Mon Nov 8 18:31:50 GMT 2010
Revision: 415
Author: apittman at gmail.com
Date: Mon Nov 8 10:31:23 2010
Log: Fix a couple of problem with the new launch_mode code:
Only use "rmgr" if it provided a launch command, some of them don't
which lead to the wrong thing happening.
Check for "pdsh" being requested seperatly for pdsh being installed
so that the correct error message is reported to the user.
http://code.google.com/p/padb/source/detail?r=415
Modified:
/trunk/src/padb
=======================================
--- /trunk/src/padb Mon Nov 8 10:27:13 2010
+++ /trunk/src/padb Mon Nov 8 10:31:23 2010
@@ -3761,13 +3761,16 @@
return %pcmd;
}
} elsif ( $mode eq 'rmgr' ) {
- return %pcmd;
+ if ( defined $pcmd{command} ) {
+ return %pcmd;
+ }
} elsif ( $mode eq 'ssh' ) {
if ( @hosts == 1 ) {
$pcmd{command} = "ssh $hosts[0]";
return %pcmd;
}
- } elsif ( $mode eq 'pdsh' and $have_pdsh ) {
+ } elsif ( $mode eq 'pdsh' ) {
+ next unless ($have_pdsh);
$pcmd{require_inner_callback} = 1;
my $hlist = join q{,}, @hosts;
More information about the padb-devel
mailing list