[padb] r461 committed - Fix some issues with how messages/errors from the DLL are reported....

[padb at googlecode.com]

Revision: 461
Author:   apittman at gmail.com
Date:     Sat Jan  4 20:53:45 2014 UTC
Log:      Fix some issues with how messages/errors from the DLL are  
reported.

When showing the user a message also show which function reported it.
Show error messages when run as -Q as well as -q
Show a error message when minfo itself detects errors.

http://code.google.com/p/padb/source/detail?r=461

Modified:
  /trunk/src/minfo.c
  /trunk/src/padb

=======================================
--- /trunk/src/minfo.c	Sat Jan  4 19:23:59 2014 UTC
+++ /trunk/src/minfo.c	Sat Jan  4 20:53:45 2014 UTC
@@ -142,7 +142,9 @@

      i = sscanf(ans, "%lx",(long *)&addr);
      if ( i != 1 ) {
-	printf("Failed sscanf %d 0x%lx\n",i,(long)addr);
+	char message[256];
+	sprintf(message,"Failed sscanf looking for '%s': %d  
0x%lx",name,i,(long)addr);
+	show_warning(message);
  	return NULL;
      }

=======================================
--- /trunk/src/padb	Sat Jan  4 19:23:59 2014 UTC
+++ /trunk/src/padb	Sat Jan  4 20:53:45 2014 UTC
@@ -7197,6 +7197,10 @@
          if ( defined $bytes_to_read ) {
              $str_value .= $r;
              if ( length $str_value eq $bytes_to_read + 1 ) {
+
+                # Chomp twice here, once to remove the newline that minfo
+                # added, once to remove any newline from the message  
itself.
+                chomp $str_value;
                  chomp $str_value;
                  if ($str_global) {
                      $global{$str_name} = $str_value;
@@ -7559,8 +7563,8 @@
      my ( $carg, $lines, $three ) = @_;

      my %headers = (
-        ihqm            => 'Message from DLL',
-        phqm            => 'Message from DLL',
+        ihqm            => 'Message from DLL (mqs_image_has_queues)',
+        phqm            => 'Message from DLL (mqs_process_has_queues)',
          dllerror        => 'Error string from DLL',
          warning         => 'Warning message from minfo',
          dlldebugmessage => 'Debug message from DLL',
@@ -10603,6 +10607,7 @@
      };

      $allfns{mqueue} = {
+        out_handler => \&mpi_queue_output_handler,
          handler_one => \&show_mpi_queue_one,
          needs_gdb   => 1,
          arg_long    => 'mpi-queue',