<br><font size=2 face="sans-serif">On Jan 27 2010 at 18:30 </font><font size=1 face="sans-serif"><b>Ashley Pittman <ashley@pittman.co.uk></b></font><font size=2 face="sans-serif"> wrote:</font>
<br><font size=2 face="sans-serif">> </font><font size=2 face="Courier New">As they are dependant on each other could you send them as a single, combined patch please.</font>
<br>
<br><font size=2 face="sans-serif">I'm sending the combined patch against r386:</font>
<br>
<br>
<br>
<br><font size=2 face="Courier New">>I'm not sure that your loop over @chaps in lsfmpich2wr_get_mpiproc() is correct, should the if ($found_app != 0) test be outside of the main loop? Again a comment explaining what the code is trying to extract would be >useful here.</font>
<br>
<br><font size=2 face="Courier New">This subroutine is trying to extract a file path wich is just after param --app</font>
<br><font size=2 face="Courier New">ex: --app foo ..., (foo is the file) so the test is just for the loop on every fields(words) for this line.</font>
<br>
<br><font size=2 face="Courier New">You are free to optimize my codings, just got to get them working.</font>
<br>
<br><font size=2 face="Courier New">Thipadin,</font>
<br><font size=2 face="Courier New">Regards.</font>
<br>
<br>
<br>
<br>
<br>
<table width=100%>
<tr valign=top>
<td>
<td><font size=1 face="sans-serif"><b>Ashley Pittman <ashley@pittman.co.uk></b></font>
<p><font size=1 face="sans-serif">01/27/2010 06:30 PM</font>
<br>
<td><font size=1 face="Arial"> </font>
<br><font size=1 face="sans-serif"> Pour : thipadin.seng-long@bull.net</font>
<br><font size=1 face="sans-serif"> cc : padb-devel@pittman.org.uk, Andry.Razafinjatovo@bull.net, florence.vallee@bull.net, Sylvain Jeaugey <sylvain.jeaugey@bull.net></font>
<br><font size=1 face="sans-serif"> Objet : Re: [padb] Réf. : Re: Réf. : Bull changes ( with LSF -mpich2wrapper patch )</font></table>
<br>
<br><font size=2 face="Courier New"><br>
On 21 Jan 2010, at 14:20, thipadin.seng-long@bull.net wrote:<br>
> <br>
> I get back to you after a short break, as I've been doing some validation on a openmpi spawn functionality. <br>
> Now I've finished what you've asked me above, I am just sending both patches. <br>
> One for lsf-mpich2 wrapper, and the other one with lsf-openmpi wrapper. I did it against r386 version. <br>
> Both are alike and have many common sub routines. As the patches are seperated some routines <br>
> are in both patches. I prefer you integrate once as you can factorize. <br>
> If you need some 'ps' or 'bjobs' command layouts to understand the coding, please ask, I'll send you. <br>
<br>
As they are dependant on each other could you send them as a single, combined patch please.<br>
<br>
I don't have systems I can test this on as I don't have lsf but I would like to understand the code, could you put together a paragraph for each rmgr describing how the underlying resource manager lays out processes and how padb finds it's information. I'm particularly interested in why it has to ssh around to different nodes to see the information it needs.<br>
<br>
With the ps command you can prevent the printing of headers by using the option "-o pid=,ppid=,cmd=" which will avoid the special case for removing these later on. Stripping the leading spaces from ps output is already done in get_extended_process_list(), can you use the same regexp in get_line_ppid() for clarity please.<br>
<br>
I'm not sure that your loop over @chaps in lsfmpich2wr_get_mpiproc() is correct, should the if ($found_app != 0) test be outside of the main loop? Again a comment explaining what the code is trying to extract would be useful here.<br>
<br>
Ashley,<br>
<br>
-- <br>
<br>
Ashley Pittman, Bath, UK.<br>
<br>
Padb - A parallel job inspection tool for cluster computing<br>
http://padb.pittman.org.uk<br>
<br>
</font>
<br>
<br>